Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for chat.postMessage API method #15

Merged
merged 1 commit into from
Feb 3, 2015
Merged

Add support for chat.postMessage API method #15

merged 1 commit into from
Feb 3, 2015

Conversation

paulhammond
Copy link
Contributor

This pull request adds support for the chat.postMessage API method

@silentrob
Copy link

This is super useful. Just a side note, Bot users are not authorized to call this endpoint.
(I know you know that. Just saying generally to anyone else wanting this.)

@paulhammond
Copy link
Contributor Author

Actually, as of a few minutes ago, they are. As I mentioned over in slackapi/hubot-slack#148 this is provisional and might change but probably won't...

@silentrob
Copy link

🍻 👍

@_client.logger.debug params
@_client._apiCall "chat.postMessage", params, @_onPostMessage

_onPostMessage: (data) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought...

There are a bunch of these _on{{ApiMethod}} methods that just call the logger. Not really bad but might be easier to just pass around the logger directly instead of a bunch of different methods that wrap it (unless there's some other purpose I'm missing).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fair point - I was just copying the existing pattern. I'm open to other approaches here!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea you definitely didn't start it here. Not a big deal, just something I noticed.

paulhammond added a commit that referenced this pull request Feb 3, 2015
Add support for chat.postMessage API method
@paulhammond paulhammond merged commit 3b06359 into slackapi:master Feb 3, 2015
@paulhammond paulhammond deleted the chat.postMessage branch February 3, 2015 21:07
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this pull request Mar 20, 2019
aoberoi added a commit to aoberoi/node-slack-sdk that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants